Consistent return type from lstirling_asym(x::Float32)
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in #140
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 55.47% 56.60% +1.13%
==========================================
Files 13 13
Lines 530 530
==========================================
+ Hits 294 300 +6
+ Misses 236 230 -6
Continue to review full report at Codecov.
|
devmotion
reviewed
Apr 2, 2022
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
|
Thanks for the suggestion @devmotion |
devmotion
reviewed
Apr 2, 2022
|
I hope this is good to go now. |
devmotion
approved these changes
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #140. I also changed the construction to use the previously calculated Float64 values.
Closes #140